unnecessary_safety_comment: check for impl items as well
#15631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for 2a73682
This comment will be updated if you push new changes |
zihan0822
force-pushed
the
safety-comment-on-impl-item
branch
from
0226e65 to
802c81b
Compare
|
By looking at the lintcheck result, it looks like you might have false positives when macros are involved. |
|
Previous implementation still lints internal macro. I followed that rule. Should we change that? |
changelog: [`unnecessary_safety_comment`]: check for impl items as well Signed-off-by: Zihan <[email protected]>
zihan0822
force-pushed
the
safety-comment-on-impl-item
branch
from
802c81b to
2a73682
Compare
|
r? clippy |
|
☔ The latest upstream changes (possibly f3c020c) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15034
changelog: [
unnecessary_safety_comment]: check for impl items as well